Remove the old block preview implementation #21096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
ajitbohra,
ellatrix,
jorgefilipecosta,
Soean and
talldan
as code owners
|
Size Change: -627 B (0%) Total Size: 858 kB
ℹ️ View Unchanged
|
youknowriad
added
the
Needs Dev Note
youknowriad
removed
the
Needs Dev Note
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #21014 We removed the old scaled block preview usage and switched to auto-height by default.
In this PR, I'm removing the old implementation entirely as it's more complex, more cumbersome without a big additional value.
I'm adding a tentative "Needs devnote" to document this change.