[RNMobile] Enable edit button over Image blocks for Android #21165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enable "Edit" image option in Android as well
2 tasks
mchowning
reviewed
Mar 27, 2020
| @@ -607,8 +606,7 @@ export class ImageEdit extends React.Component { | |||
| ! isUploadInProgress && | |||
| ! isUploadFailed && | |||
| finalWidth && | |||
| finalHeight && | |||
| showMediaEditorButton && ( | |||
| finalHeight && ( | |||
There was a problem hiding this comment.
You're deleting a ( here, but I don't see that you're deleting the matching )?
There was a problem hiding this comment.
I don't think so 🤔. Bracket was added to the previous line.
There was a problem hiding this comment.
You're right. Don't know what I was thinking. 🤦♂
mchowning
approved these changes
Mar 27, 2020
There was a problem hiding this comment.
These changes are working well! 👍
I've confirmed that the text alignment issue in the bottom sheet that you observed is not due to any changes in this PR, so I think we can merge this.
etoledom
added
the
Mobile App - i.e. Android or iOS
etoledom
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
Agreed with @mchowning !
Tested on Android and WPAndroid via wordpress-mobile/WordPress-Android#11557
Working like a charm! 🎉
Thank you so much for this PR @ashiagr !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
showMediaEditorButtonconstreferences to enable edit button over Image blocks for Android as well.The button was originally added as part of these PRs #19723, wordpress-mobile/gutenberg-mobile#1782 and was enabled only for iOS till now.
gutenberg-mobilerelated PR: wordpress-mobile/gutenberg-mobile#2062WPAndroidIssue: wordpress-mobile/WordPress-Android#11147(I don't have permissions on the main gutenberg repo, creating it in a fork-branch)
How has this been tested?
Creating it as a draft PR as it still needs to be tested.
Screenshots
To be included once tested.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: