Update Dashicons #2118
Merged
Update Dashicons #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't merge this. There's a weird amount of red in this diff. I'm pushing as a branch so we can discuss how it regressed in the upstream dashicons repo, possibly as part of #1888.
Codecov Report
@@ Coverage Diff @@
## master #2118 +/- ##
=========================================
+ Coverage 20.33% 22% +1.66%
=========================================
Files 135 136 +1
Lines 4238 4558 +320
Branches 722 807 +85
=========================================
+ Hits 862 1003 +141
- Misses 2844 2967 +123
- Partials 532 588 +56
Continue to review full report at Codecov.
|
This one has the table icons.
|
Pushed 431ad49 to reintroduce case ordering (see WordPress/dashicons#222), which should reduce number of changes. |
aduth
approved these changes
Aug 2, 2017
|
There was another missing upstream change. See also WordPress/dashicons#223, resolved here by 9808405. Order of the condition gets mixed up, but same effect. |
|
Thank you! |
ceyhun
pushed a commit
that referenced
this pull request
Apr 22, 2020
…reen (#2118) * update ref to master * update RELEASE-NOTES.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge this. There's a weird amount of red in this diff. I'm pushing as a branch so we can discuss how it regressed in the upstream dashicons repo, possibly as part of #1888.
BTW not trying to assign blame here or anything, it's probably somewhat trivial to fix, just making sure.
CC: @mtias, @EphoxJames (there appear to be some table icons) and @aduth