-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dashicons #2118
Update Dashicons #2118
Conversation
Don't merge this. There's a weird amount of red in this diff. I'm pushing as a branch so we can discuss how it regressed in the upstream dashicons repo, possibly as part of #1888.
Codecov Report
@@ Coverage Diff @@
## master #2118 +/- ##
=========================================
+ Coverage 20.33% 22% +1.66%
=========================================
Files 135 136 +1
Lines 4238 4558 +320
Branches 722 807 +85
=========================================
+ Hits 862 1003 +141
- Misses 2844 2967 +123
- Partials 532 588 +56
Continue to review full report at Codecov.
|
This one has the table icons.
Pushed 431ad49 to reintroduce case ordering (see WordPress/dashicons#222), which should reduce number of changes. |
There was another missing upstream change. See also WordPress/dashicons#223, resolved here by 9808405. Order of the condition gets mixed up, but same effect. |
Thank you! |
…reen (#2118) * update ref to master * update RELEASE-NOTES.txt
Don't merge this. There's a weird amount of red in this diff. I'm pushing as a branch so we can discuss how it regressed in the upstream dashicons repo, possibly as part of #1888.
BTW not trying to assign blame here or anything, it's probably somewhat trivial to fix, just making sure.
CC: @mtias, @EphoxJames (there appear to be some table icons) and @aduth