Env: Bind "core" files to tests environment #21195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a local source for "core" we want to ensure two things: 1. That changes the user makes within the "core" directory are served in both the development and tests environments. 2. That the development and tests environment use separate databases and `wp-content/uploads`. Only (2) was working because the tests environment served everything from a totally separate copy of WordPress. The fix is to bind every file except wp-config.php and wp-content from the local "core" directory to the tests environment.
noisysocks
added
[Type] Bug
|
Size Change: 0 B Total Size: 856 kB ℹ️ View Unchanged
|
noisysocks
commented
Mar 27, 2020
noisysocks
commented
Mar 27, 2020
| // https://github.com/WordPress/gutenberg/issues/21164 | ||
| `${ config.coreSource.testsPath }:/var/www/html`, | ||
| ...fs | ||
| .readdirSync( config.coreSource.path ) |
There was a problem hiding this comment.
I don't really like how buildDockerComposeConfig has become an "impure" function.
|
OK, I'm happy with this.
I tested this and all seems gucci 👌. |
tellthemachines
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21164.
When using a local source for "core" we want to ensure two things:
wp-content/uploads.Only (2) was working because the tests environment served everything from a totally separate copy of WordPress.
The fix is to bind every file except
wp-config.phpandwp-contentfrom the local "core" directory to the tests environment.To test:
Create a
.wp-env.jsonthat has its"core"set to a local path:{ "core": "/path/to/wordpress-develop/build" }Run
wp-env start.Make changes to something in
wordpress-develop/build.The changes should appear in both
localhost:8888andlocalhost:8889.We should also verify that this does not break existing flows, e.g. running
wp-env startwith"core": nulland"core: "WordPress/WordPress".