Small updates to template selector in site editor #21202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mtias
commented
Mar 27, 2020
mtias
commented
- Simplify DOM structure of menu items and their labels.
- Remove icon from dropdown toggle.
- Update design of "customized" dot.
- Simplify DOM structure of menu items and their labels. - Remove icon from dropdown toggle. - Update design of "customized" dot.
|
Size Change: +60 B (0%) Total Size: 856 kB
ℹ️ View Unchanged
|
youknowriad
reviewed
Mar 30, 2020
| @@ -102,7 +96,7 @@ export default function TemplateSwitcher( { | |||
| className: 'edit-site-template-switcher__popover', | |||
| position: 'bottom right', | |||
| } } | |||
| icon={ layout } | |||
| icon={ null } | |||
There was a problem hiding this comment.
What happens if we just drop the prop?
There was a problem hiding this comment.
It renders a default icon :/
youknowriad
approved these changes
Mar 30, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.