Components: SlotFill: Guard property access to possibly-undefined slot #21205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
|
Size Change: +9 B (0%) Total Size: 856 kB
ℹ️ View Unchanged
|
draganescu
approved these changes
Mar 27, 2020
jorgefilipecosta
approved these changes
Mar 27, 2020
There was a problem hiding this comment.
I verified this PR fixes the issue in 5.4 👍
@diegohaz feel free to a last check on the issue.
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 27, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 27, 2020
diegohaz
added a commit
that referenced
this pull request
Mar 28, 2020
diegohaz
added a commit
that referenced
this pull request
Mar 30, 2020
* Add failing test on slot-fill * Apply #21205 to fix the failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crash mentioned at #18560 (comment)
Related: #19242
This pull request seeks to update the implementation of the new SlotFill
unregisterSlotadded in #19242 to guard property access on its condition for testing an equalrefvalue. While based on my comment at #19242 (comment) it is not entirely clear the reason for which a duplicate call is made tounregisterSlotwhen the slot is already unregistered, this avoids a situation where the absence of the slot would throw an error. The updated logic is such that if theslotis not defined, it will fall back to to returning the previous slots valueprevSlots, since if the slot was not defined inprevSlotsalready, thenprevSlotswill continue to be the valid next state.Testing Instructions:
Verify no error occurs.
I will need some advice on implementing automated tests here. There are tests for the Slot / Fill components, but two issues:
Providerimplementation. I'm not sure if this was intended to have been removed as part of Components: Refactor SlotFill #19242. In any case, I am not sure there is complete test coverage for the new implementations added in Components: Refactor SlotFill #19242.