Upgrade Reakit to version 1.0.0-rc.0 #21300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegohaz
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
gziolo
reviewed
Mar 31, 2020
| const toolbarState = useToolbarState( { loop: true } ); | ||
| // Passing baseId for server side rendering (which includes snapshots) | ||
| // If an id prop is passed to Toolbar, toolbar items will use it as a base for their ids | ||
| const toolbarState = useToolbarState( { loop: true, baseId: props.id } ); |
gziolo
reviewed
Mar 31, 2020
package-lock.json
Outdated
| "rememo": "^3.0.0", | ||
| "tinycolor2": "^1.4.1", | ||
| "uuid": "^3.3.2" | ||
| }, | ||
| "dependencies": { |
There was a problem hiding this comment.
you should install reakit in the root of the project and then remove it to move it to the root level in the lock file
|
Size Change: +3.75 kB (0%) Total Size: 870 kB
ℹ️ View Unchanged
|
gziolo
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades Reakit to version 1.0.0-rc.0, which fixes future problems with concurrent mode by addressing React 16.13 warnings.