-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Reakit to version 1.0.0-rc.0 #21300
Conversation
const toolbarState = useToolbarState( { loop: true } ); | ||
// Passing baseId for server side rendering (which includes snapshots) | ||
// If an id prop is passed to Toolbar, toolbar items will use it as a base for their ids | ||
const toolbarState = useToolbarState( { loop: true, baseId: props.id } ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition 👍
package-lock.json
Outdated
"rememo": "^3.0.0", | ||
"tinycolor2": "^1.4.1", | ||
"uuid": "^3.3.2" | ||
}, | ||
"dependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should install reakit
in the root of the project and then remove it to move it to the root level in the lock file
Size Change: +3.75 kB (0%) Total Size: 870 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you for taking care of it. Travis is green so I assume all is fine.
This upgrades Reakit to version 1.0.0-rc.0, which fixes future problems with concurrent mode by addressing React 16.13 warnings.