Fix reusable block horizontal padding regression. #21312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
[Type] Regression
jasmussen
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
|
Size Change: +20 B (0%) Total Size: 889 kB
ℹ️ View Unchanged
|
|
I'm still seeing top/bottom margin added to the reusable block seen here:
It looks like it's caused by one of the wrapping divs preventing neighboring margins from collapsing into each other (I think). I suspect this is the cause:
If you uncheck
|
https://github.com/WordPress/gutenberg/pull/21099/files#diff-ee2ed3adbe2578628039530c717a9a93R640 introduced a padding attached to the is-root-container. But a reusable block is also a root container. This PR unsets that.
jasmussen
force-pushed
the
try/reusable-block-padding-fix
branch
from
fe90811
to
abb52be
Compare
|
Nice catch, I'll address that in a separate PR, because this PR is only about the horizontal paddings and therefore relatively "safe", but the fix you suggest needs a little bit more scrutiny. |
jasmussen
added a commit
that referenced
this pull request
Apr 8, 2020
This is a followup and addition to #21312. It's separate because it's not a regression.
|
I created #21472 to fix the vertical margin separately. Also pushed a small fix to address a navigation mode border shift. |
|
Thanks @jasmussen. In that case, I think this one is good to go. Nice fix! |
|
Thanks! Can you approve the PR? |
MichaelArestad
approved these changes
Apr 8, 2020
|
Done! |
jasmussen
added a commit
that referenced
this pull request
Apr 10, 2020
This is a followup and addition to #21312. It's separate because it's not a regression.
jasmussen
added a commit
that referenced
this pull request
Apr 10, 2020
This is a followup and addition to #21312. It's separate because it's not a regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/WordPress/gutenberg/pull/21099/files#diff-ee2ed3adbe2578628039530c717a9a93R640 introduced a padding attached to the is-root-container. But a reusable block is also a root container.
This PR unsets that.
Before:
After: