-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement initial styling of navigation menu screen #21314
Conversation
Size Change: +343 B (0%) Total Size: 884 kB
ℹ️ View Unchanged
|
I think this is the right thing to do. Over time I'd like to see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Nice work. It's really cool to see how adaptable @wordpress/components
are now.
We'll need to make this responsive for mobile and tablet viewports but we can do that in a follow-up PR since this is all marked experimental.
} ) ) } | ||
onChange={ ( selectedMenuId ) => setMenuId( selectedMenuId ) } | ||
/> | ||
<Card className="edit-navigation-menus-editor__menu-selection-card"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A Card
! Very cool!
Let's get this in and iterate. It's a huge improvement that brings us closer to being able to test this new screen on users. I created #21337 to track making this screen responsive. @karmatosed: If there's any design feedback here, plop it into the project board and we'll get it sorted. |
Description
Closes #21284
I've implemented this using
@wordpress/components
components, some of which look different from #21284, just because of the styles of the components.We'd have to decide if we want to create variations of the styles those components offer or just stick with the out of the box styles.
There's also a question over whether some of the layout makes semantic sense. E.g. a Save Button in a Panel title.
These things can be iterated on.
How has this been tested?
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: