-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile][Monorepo] Fix linting #21349
Merged
hypest
merged 13 commits into
feat/import-gutenberg-mobile-no-squash
from
rnmobile/monorepo-fix-linting
Apr 6, 2020
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
86afc8a
Revert ignoring react-native-* from eslint
ceyhun b1f459e
Add eslint-plugin-react-native to @wordpress/eslint-plugin as a depen…
ceyhun 10208c3
Delete react-native-aztec's example project
ceyhun 51f937e
Delete react-native-aztec flowconfig
ceyhun d7d69ea
Remove react-native-editor's .eslintignore file as it will be empty
ceyhun 8fe37ba
Fix all lint-js errors
ceyhun 079eb6b
Fix @ flow, @ format lint-js warnings
ceyhun 1fb7e53
Remove remaining flow types
ceyhun 5edb589
Add missing dependencies needed for tests to react-native-editor pack…
Tug ff53e21
Ignore react-native-* packages in main unit tests
ceyhun bc3c697
Run react-native-* packages' test in main native test script
ceyhun 4d2a16d
Delete duplicate native jest config
ceyhun 475709e
Update ignore path for react-native-* packages in main unit test config
ceyhun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really minor but we could try to be a bit more consistent with
/packages/react-native-*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 👍