[RNMobile] - Layout picker - Update emoji #21373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While testing I spotted the "Envelope" -> ✉️ emoji wasn't working correctly for API Level >= 21 <=23 as well.
I tested going to the Unicode Version 1.0 from the emulator's browser and barely some rendered correctly from that list, then I checked the 6.0 version and almost all of them rendered correctly. @iamthomasbishop is there another emoji we could use as a replacement for the "Envelope" (✉️) emoji? |
|
Size Change: +1.29 kB (0%) Total Size: 885 kB
ℹ️ View Unchanged
|
2 tasks
|
@geriux For the contact one, I think we could use either “email”, “closed mailbox with raised flag”, or “memo” from the 6.0 spec. |
|
Thanks for the options @iamthomasbishop here's how they'd look:
Closed Mailbox with Raised Flag
Memo
Which one do you prefer? All three render correctly 😃 |
I think I prefer the mailbox one, but all 3 of them work just fine. |
geriux
added
[Type] Bug
chipsnyder
approved these changes
Apr 3, 2020
mkevins
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#2103Description
While testing on Android, an issue was spotted on devices with API 21 and 22 where the emoji wouldn't render properly because we were using some from a newer Unicode version. So we need to update it to make it compatible with those. While we give support to that range of OS versions we need to pick emojis from the Unicode 6.0 definition
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist: