Delete editor-styles that are no longer needed #21383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were used to prevent wp-admin styles from leaking to the editor. Now that the paragraph & heading blocks add their own variables for these properties, we can remove these styles.
|
Size Change: -47 B (0%) Total Size: 885 kB
ℹ️ View Unchanged
|
oandregal
added
the
Global Styles
youknowriad
approved these changes
Apr 3, 2020
|
I'm out for the day, but I trust Riad totally. I'd also say that regardless of whatever small things might be affected, this is a crucially important step to take, so go forth and conquer! |
I don't have a strong opinion either way. However, I lean towards not adding them: this was only previously done for the editor while adding now the fallbacks will affect both the editor & frontend. When we load the global styles they're going to be pre-filled anyway, so I guess we can land as it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #20530 (comment)
These styles were used to prevent wp-admin styles from leaking to the editor. Now that the paragraph & heading blocks add their own variables for these properties, we need to remove them so global styles are applied.
How to test
Test that it works:
Now, test that it doesn't work without these changes:
git reset --hard HEAD~1) and compile again (npm run build).