-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Env: Await test result of testPortNumberValidation #21394
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Bug
An existing feature does not function as intended
[Package] Env
/packages/env
labels
Apr 3, 2020
Size Change: 0 B Total Size: 889 kB ℹ️ View Unchanged
|
noahtallen
approved these changes
Apr 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this. Coincidentally, I also just fixed this in #21229 after I noticed the issue :)
Also, thank you for recommending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to correct an ineffective test case in
@wordpress/env
, where the test case does not await the completion of promised tasks.There are two pressing issues:
stdout
with an error, despite the test case being considered as passing (example)testPortNumberValidation
could be throwing an error and we'd not catch itThis passes:
The errors being logged are not in-fact errors. I expect the issue is that without awaiting the result of the previous, the subsequent mock will interfere with the results of others.
It's simply enough to await completion.
Alternatives to consider:
it.each
)readFile
implementation.Example
it.each
:See also: https://jestjs.io/docs/en/api#testeachtablename-fn-timeout
Testing Instruction:
Ensure unit tests pass, and there is no extra logged output: