-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint Plugin: Update ESLint and related deps to 6.8.x #21424
Conversation
Size Change: 0 B Total Size: 890 kB ℹ️ View Unchanged
|
3e301f1
to
01edda8
Compare
01edda8
to
a51f2e3
Compare
b69893b
to
a313759
Compare
|
||
/* eslint-disable-next-line jest/expect-expect */ | ||
it( 'captures logging in lifecycle', () => {} ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What even is this testing? 🤔 Not technically in scope, but considering you might have some insight here, a code comment would be helpful (if it's not encompassed in the comment of beforeAll
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is explained in beforeAll
and I added a reference as disable reason.
8f822ee
to
71b3bf3
Compare
Co-Authored-By: Andrew Duthie <andrew@andrewduthie.com>
71b3bf3
to
b0da90e
Compare
Description
This PR brings up to date all ESLint and its plugin packages used.
I had to disable
jest/expect-expect
in the Gutenberg project because we have way too many tests that don't have assertions used. In a few places, I also had to disable some local usage where it conflicts with new additions to the ESLint rules introduced for Jest.@wordpress/eslint-plugin
eslint-plugin-jest
dependency has been updated from requiring^22.15.1
to requiring^23.8.2
(#21424).eslint-plugin-jsdoc
dependency has been updated from requiring^21.0.0
to requiring^22.1.0
(#21424).eslint-plugin-react-hooks
dependency has been updated from requiring^1.6.1
to requiring^3.0.0
(#21424).eslint-plugin-react
dependency has been updated from requiring^7.14.3
to requiring^7.19.0
(#21424).@wordpress/scripts
eslint
dependency has been updated from requiring^6.1.0
to requiring^6.8.0
(#21424).How has this been tested?
npm run lint-js
Checklist: