fix/[#21440] Copy/cut input values copying entire block

[kirilzh]

Description

In block-editor/src/components/copy-handler/index.js this check does not pass

// Let native copy behaviour take over in input fields.
if ( ! hasMultiSelection() && documentHasSelection() ) {
	return;
}

because documentHasSelection() returns false. Going deeper we see there’s a check if a text fields has a selection

function documentHasSelection() {
	if ( isTextField( document.activeElement ) ) {
		return true;
	}

	const selection = window.getSelection();
	const range = selection.rangeCount ? selection.getRangeAt( 0 ) : null;

	return range && ! range.collapsed;
}

I then stumbled upon this. Hence I added a function checking only <input type="number" />.

How has this been tested?

In both Chrome and FF on MacOS.

Types of changes

Bug fix (non-breaking change) which fixes #21440 .

Checklist:

• My code is tested.
• My code follows the WordPress code style.

[youknowriad]

Should we add this inside isTextField or should it be a separate function? Or more precisely, do we consider a "number" input as a text field? I might think yes but curious what others think?

[kirilzh]

Initially I extended isTextField but later I asked myself the same question and to me it makes more sense to have them separated. I don't consider numbers as text per se. Also curious what others think : )

[youknowriad]

Code looks good to me, I'll do some testing

[youknowriad]

This seems to work very well :) Thanks for the fix.

[github-actions]

Congratulations on your first merged pull request, @kirilzh! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

[tomusborne]

This has fixed the copying part of the issue, but I'm still seeing an issue once the value is pasted back into the field. The pasted value replaces the block itself, instead of being added to the field.