Icons: Add types #21487
Merged
Icons: Add types #21487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 tasks
sirreal
reviewed
Apr 10, 2020
|
Size Change: 0 B Total Size: 903 kB ℹ️ View Unchanged
|
ockham
added
[Type] Code Quality
aduth
approved these changes
Apr 10, 2020
Co-Authored-By: Andrew Duthie <andrew@andrewduthie.com>
sirreal
reviewed
Apr 11, 2020
| @@ -3,6 +3,20 @@ | |||
| */ | |||
| import { cloneElement } from '@wordpress/element'; | |||
|
|
|||
| // Disable reason: JSDoc linter doesn't seem to parse the union (`&`) correctly. | |||
| /* eslint-disable jsdoc/valid-types */ | |||
| /** @typedef {{icon: JSX.Element, size?: number} & import('react').ComponentPropsWithoutRef<'SVG'>} IconProps */ | |||
There was a problem hiding this comment.
This isn't strictly accurate, but this is closer to what we intend. I believe ComponentPropsWithoutRef<'SVG'> is a bug.
/** @typedef {{icon: JSX.Element, size?: number} & import('@wordpress/primitives').SVGProps} IconProps */
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Taking notes from #21248. Depends on #21482. Part of #18838.
Includes a fix to
@wordpress/primitivesto makeSVG'sisPressedprop optional (oversight in #21482).How has this been tested?
Types of changes
Add types.
Checklist:
cc/ @sirreal