Skip RTL for Separator spacing #21525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes padding flipping for dots, since they will still render LTR in mobile before:
senadir
added
[Type] Bug
senadir
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
youknowriad
added
Needs Dev Note
|
Size Change: -1 B Total Size: 903 kB
ℹ️ View Unchanged
|
Can you clarify this, if they do the same thing, it shouldn't be broken, just duplicated right? |
youknowriad
approved these changes
Apr 9, 2020
|
if a theme copies these styles to define another value for padding padding-left: 1em;it RTL that value will be flipped plus the original one coming from default styles padding-left: 2em; //original
padding-right: 1em; |
|
This assumes the theme has RTL support. Very few do I believe. I'm not 100% this PR deserves a dev note. |
No strong feelings here, happy to merge as is. |
youknowriad
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes padding flipping for dots, since they will still render LTR in mobile
Before:
After:
Some themes also override this value, and they apply the same style, the styles will now be broken on mobile for them, so a dev note should also be included.
possibly something like this?