Fix/calendar focus #21600
Merged
Fix/calendar focus #21600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
[Focus] Accessibility (a11y)
jasmussen
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
jasmussen
commented
Apr 15, 2020
| .CalendarDay { | ||
| font-size: $default-font-size; | ||
| border: 1px solid transparent; | ||
| border: none; |
There was a problem hiding this comment.
By setting this to none, no border should show up on regular days in Windows 10 high contrast mode.
jasmussen
commented
Apr 15, 2020
| border-radius: $radius-round; | ||
| text-align: center; | ||
|
|
||
| &:focus { | ||
| box-shadow: inset 0 0 0 $border-width-focus theme(primary), inset 0 0 0 #{ $border-width-focus + $border-width } $white; |
There was a problem hiding this comment.
The focus style is drawn using box shadows to create a circle. There's an inset white lower layer shadow to make it visible even on a selected day.
Windows 10 high contrast mode gets a transparent outline instead, which it makes opaque, and it strips away the box shadow.
jasmussen
commented
Apr 15, 2020
| } | ||
|
|
||
| .CalendarDay__selected { | ||
| background: theme(primary); | ||
| border: 2px solid transparent; // This indicates selection in Windows 10 high contrast mode. |
There was a problem hiding this comment.
On a selected day, we explicitly paint a solid, but transparent border. This will show up as a round border in Windows 10 high contrast mode.
But the outline will also show up.
So focus in Windows 10 high contrast mode is a square rectangle, and seleted is a round circle. They stack:
|
Size Change: +237 B (0%) Total Size: 840 kB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15929.
Alternative to #15962.
This PR adds a better focus style to calendar days, and ensures that it works in Windows 10 high contrast mode: