Fix buttons styling for old markup #21642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
|
Size Change: +49 B (0%) Total Size: 841 kB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Apr 16, 2020
There was a problem hiding this comment.
In my testing, this appears to work as intended. These two are before and after, in the vanilla style:
That button in the middle is the legacy markup.
I'm seeing a separate issue with colors not working in TwentyTwenty, but that appears unrelated and probably twentytwenty at fault.
|
Will there be a quick bug release for this issue? |
|
Probably yes |
youknowriad
added a commit
that referenced
this pull request
Apr 16, 2020
|
Thanks for the fix, @youknowriad! |
This was referenced Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #21624
This PR makes sure the styling of the buttons stay correct even if applied on the previous buttons markup.
Testing instructions