Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Visual issue on windows with 782px #21661

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Fix: Visual issue on windows with 782px #21661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/base-styles/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,13 +151,13 @@
#{$selector} { /* Set left position when auto-fold is not on the body element. */
left: 0;

@include break-medium() {
@media (min-width: #{ ($break-medium + 1) }) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun :) do you think the mixins should be updated to do this directly or not?

left: $admin-sidebar-width;
}
}

.auto-fold #{$selector} { /* Auto fold is when on smaller breakpoints, nav menu auto collapses. */
@include break-medium() {
@media (min-width: #{ ($break-medium + 1) }) {
left: $admin-sidebar-width-collapsed;
}

Expand All @@ -170,13 +170,13 @@
.folded #{$selector} {
left: 0;

@include break-medium() {
@media (min-width: #{ ($break-medium + 1) }) {
left: $admin-sidebar-width-collapsed;
}
}

/* Mobile menu opened. */
@media (max-width: #{ ($break-medium) }) {
@media (max-width: #{ ($break-medium + 1) }) {
.auto-fold .wp-responsive-open #{$selector} {
left: $admin-sidebar-width-big;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/interface/src/components/interface-skeleton/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ html.interface-interface-skeleton__html-container {
bottom: 0;

// Adjust to admin-bar going small.
@include break-medium() {
@media (min-width: #{ ($break-medium + 1) }) {
top: $admin-bar-height;

.is-fullscreen-mode & {
Expand Down