-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken links in handbook #21686
Fix broken links in handbook #21686
Conversation
Thanks for these contributions, it does fix a couple of links but I don't think we want to hardcode the links to the github.com repository, they should stay relative and on publish they get translated to Block Editor handbook links also. Especially now since the handbook is being published off the release tag, and the links will point to the master branch, things will get out of sync or break when moved. |
@mkaz I agree. I suppose this is more of a stopgap to fix 404s until the code to generate the rest of the handbook is written. There are already a lot of links hardcoded to GitHub that exist (40 results in 22 files in I can roll back the ones that link to master in this PR if you'd like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose a link to Github is better than broken outright. I'll approve and we can fix downstream.
I thought we had the deep linking into packages fixed but I can't find the corresponding ticket. @nosolosw was linking into packages resolved or still open?
7838ad9
to
05eb110
Compare
I don't remember that we fixed this. However, I've also been a bit out of the loop in all regarding docs so I may have missed it. Actually, now that this PR is merged but I don't see the changes in the handbook. Is that because we now pin the handbook to a branch? If that's the case, I wonder if we should cherry-pick commits the handbook branch from now on. |
@nosolosw Yes, the handbook is pinned to |
Description
This fixes a handful of links from the docs that were broken either in GitHub or in the Block Editor Handbook including the one mentioned in #15767.
Did a quick check via grep for relative links that don't match the criteria in the Using Links docs, confirmed which ones were actually broken, and updated them accordingly.
Types of changes
Documentation fixes
Checklist: