Adds deprecation notice to useApiFetch hook
#21723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Package] Deprecated
getdave
requested review from
retrofox,
marekhrabe,
youknowriad,
noisysocks,
aduth and
tellthemachines
This was referenced Apr 20, 2020
|
Size Change: -32 B (0%) Total Size: 842 kB
ℹ️ View Unchanged
|
marekhrabe
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
This works well for me and I'm able to see the deprecation notice in my console. It's incredibly long which might actually make it hard to observe but that has nothing to do with this usage.
Regarding the general direction to deprecate this feature, I'm deferring to the discussion in #21674 which looks like this approach is a go.
getdave
force-pushed
the
fix/deprecate-use-api-fetch-hook
branch
from
242e353
to
c8d95dd
Compare
|
@aduth if you find time to review this please note:
|
Gutenberg follows WordPress's versioning conventions. There will be no 7.11.0. 8.0.0 comes after 7.9.0, so 8.1.0 would be the correct removal version. |
aduth
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been extracted from #21674.
As per [advice here from @aduth](See #21674 (comment)) this PR adds a deprecation notice to
useApiFetch.The work to remove this hook from usage within the Core Navigation Block is handled in a separate PR.
Description
Adds a deprecation warning to the
useApiFetchhook within@wordpress/api-fetch.Questions
How has this been tested?
npm install && npm run devconsoledrawer.useApiFetchhook.Please note: the work to remove this hook from usage within the Core Navigation Block is handled in a separate PR.
Screenshots
Types of changes
Checklist: