Allow title and button-based appender to inherit styles. #21749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: -22 B (0%) Total Size: 842 kB
ℹ️ View Unchanged
|
|
So, I tried to test:
Nothing happens. It is b/c of the theme? |
|
Thank you for looking! And sorry for not including better steps to test. TwentyTwenty is not loading editor styles correctly, so it will not make a difference there.
If all looks correct, this should be good to go :) |
|
Fixes #21724. |
jasmussen
force-pushed
the
try/appender-inherit-fonts
branch
from
8d0fbf2 to
1f373fd
Compare
|
I'm getting a bunch of failed e2e tests on this one, which seem completely unrelated to the fact that this is just CSS. Any insights? |
jasmussen
force-pushed
the
try/appender-inherit-fonts
branch
from
1f373fd to
74ded9d
Compare
karmatosed
approved these changes
Apr 22, 2020
File under "should've probably done this sooner", this PR allows the title field and the initial appender to inherit the theme styles defined by an editor style. In the past this wasn't possible due to how things were structured. But as it is, those styles are inherited by what is applied to the `editor-styles-wrapper`, which means this works both for themes that don't register and editor style — it looks like before — but now it also works for themes that do.
jasmussen
force-pushed
the
try/appender-inherit-fonts
branch
from
74ded9d to
c1e7e55
Compare
|
Thanks for the approval. I've tested this well and it's a trivial code change so I'm going to go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File under "should've probably done this sooner", this PR allows the title field and the initial appender to inherit the theme styles defined by an editor style.
In the past this wasn't possible due to how things were structured. But as it is, those styles are inherited by what is applied to the
editor-styles-wrapper, which means this works both for themes that don't register and editor style — it looks like before — but now it also works for themes that do.Before, vanilla style:
After, vanilla style:
After, with the following CSS registered as an editor style:
Because the title is not inside an
h1element, we can't yet inherit font sizes and weights there. But this will be fixed once the title element becomes an actual block.