-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish RSS block. #21773
Merged
Merged
Polish RSS block. #21773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Block library
/packages/block-library
[Block] RSS
Affects the RSS Block - used to display entries from an RSS/Atom feed
labels
Apr 21, 2020
Size Change: -7 B (0%) Total Size: 842 kB
ℹ️ View Unchanged
|
ZebulanStanphill
force-pushed
the
update/polish-rss-block
branch
from
April 21, 2020 23:27
775e3f7
to
fb3af1e
Compare
ZebulanStanphill
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
April 21, 2020 23:50
Soean
approved these changes
Apr 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for polishing, works great.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] RSS
Affects the RSS Block - used to display entries from an RSS/Atom feed
[Package] Block library
/packages/block-library
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR polishes the RSS block. I did the following:
block.json
andregister_block_from_metadata
.blocks-rss__placeholder-form
changed towp-block-rss__placeholder-form
.blocks-rss__placeholder-input
changed towp-block-rss__placeholder-input
.Checklist: