-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archives block: use block.json. #21775
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Block library
/packages/block-library
[Block] Archives
Affects the Archives Block
labels
Apr 22, 2020
Size Change: +60 B (0%) Total Size: 842 kB
ℹ️ View Unchanged
|
Soean
requested changes
Apr 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a little typo.
ZebulanStanphill
requested review from
ajitbohra,
jorgefilipecosta and
talldan
as code owners
April 22, 2020 12:07
Soean
approved these changes
Apr 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
ZebulanStanphill
force-pushed
the
update/archives-block-use-block-json
branch
from
April 22, 2020 13:21
601be29
to
880d7ab
Compare
ZebulanStanphill
force-pushed
the
update/archives-block-use-block-json
branch
from
April 22, 2020 13:23
880d7ab
to
ec787b9
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Archives
Affects the Archives Block
[Package] Block library
/packages/block-library
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates Archives block to use a
block.json
file.Checklist: