Add Animoto, Dailymotion block embed icons #21882
Conversation
enriquesanchez
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
|
Size Change: -1.56 kB (0%) Total Size: 833 kB
ℹ️ View Unchanged
|
enriquesanchez
changed the title
|
Build fails are because of linting errors in the svgs being exported. Feels a little unnecessary, but they're getting tripped up because there are multiple attributes on the The Dailymotion one could probably be done with |
|
Thank you for the fix and the review, @earnjam! 🙏 |
|
And has the license and terms of these logos been checked? |
|
Good thought @carolinan. Many tech companies allow usage of their logos within apps and websites and will have brand usage guidelines to clarify their rules (Facebook, Twitter, Spotify, Vimeo, etc all have great documentation for this). I did a quick check on the two sites included in this PR.
It's likely ok, but there are some grammar errors in that run-on sentence that make it murky. Dailymotion has this in their API terms:
I'm not sure how well that would hold up where even displaying the company name for any purpose is prohibited without written authorization. By those terms we can't even have the embed block at all without asking them first. But we still want to make sure we're working with these companies and using logos according to their preferences and allowances. Unless they have usage terms clearly spelled out online (like the ones I mentioned earlier), we probably do need to be reaching out to all platforms for which we want to bundle logos to get written confirmation. I don't imagine any would say no, but it's the safe practice. |
|
It is also about whether the icons have been created by the team, or downloaded from a third party site. |
|
Reading further in that thread, I think the legal perspective from Paul clears it up that it's fine to use the logos. Seems the only concern would be plucking some custom asset from a non-GPL icon library. |
This PR adds a couple missing embed block icons (Animoto and Dailymotion), partly addressing #9124. I don't intend to add all of the missing icons here, to avoid it going stale.