Import from individual react-dates component #21914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the tree-shaking issues in `react-dates` that end up causing too much of the library to be imported when importing from the index.
sgomes
added
[Type] Performance
sgomes
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
|
I'm loving these PRs @sgomes :) Thanks for your help with the bundle size. |
|
Size Change: -18.5 kB (2%) Total Size: 816 kB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Apr 27, 2020
|
Thank you for the review, @youknowriad! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is only one
react-datescomponent in use in Gutenberg, which is currently being imported with a named import:This PR changes that to importing the internal library component directly:
This is more fragile with regards to library updates, since it uses knowledge of package internals, but it avoids the tree-shaking issues in
react-datesthat end up causing too much of the library to be imported when importing from the index.This should save around 96KB on the components chunk, or 19KB over the wire, although the GitHub action will have the final say.
I believe the trade-off is worth it, since it basically only involves some extra vigilance when updating
react-dateversions.Partially works towards resolving #21820.
How has this been tested?
Ran unit tests, performed build, and performed some ad-hoc testing of date picker functionality.
Types of changes
This is essentially a bug fix, in that it works around what I'd consider a bug in
react-dates: that it doesn't tree-shake correctly.Checklist: