Try better inserter toggle styling. #22016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6 B (0%) Total Size: 825 kB
ℹ️ View Unchanged
|
|
To clarify: The two screenshots are identical, and they should be. The thing to test for is if you see the same, and no regressions elsewhere (given the scoping I can't imagine how there would be). This is simply a code improvement to reduce the specificity of the selector, allow it to inherit in contexts that don't have identical markup. |
swissspidy
approved these changes
May 4, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One letter CSS change that allows better inheritance of this particular inserter style.
Before:
After:
We still need to revisit #21870, this is not in place of that, it's merely a small code quality change that benefits gutenberg contexts that exist outside of wp-admin.