Use theme color for focus. #22261
Merged
Use theme color for focus. #22261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
[Type] Code Quality
|
Size Change: +912 B (0%) Total Size: 825 kB
ℹ️ View Unchanged
|
jasmussen
force-pushed
the
update/use-theme-colors
branch
from
0a92156
to
fc19068
Compare
jasmussen
force-pushed
the
update/use-theme-colors
branch
from
fc19068
to
e27ee6d
Compare
draganescu
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting a small bit from #20460, which uses the theme color to color selection styles. Before:
After:
This theme color is already used for focus styles and other things. I think we should redo all the color themes, and even how things are styled, but that's separate. This is just removing a hardcoded color.