Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor colors for themes not loading color palettes #22356

Merged
merged 5 commits into from
Jul 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 28 additions & 4 deletions packages/block-editor/src/components/block-list/block.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,30 @@ import { Block } from './block-wrapper';

export const BlockListBlockContext = createContext();

/**
* Merges wrapper props with special handling for classNames and styles.
*
* @param {Object} propsA
* @param {Object} propsB
*
* @return {Object} Merged props.
*/
function mergeWrapperProps( propsA, propsB ) {
const newProps = {
...propsA,
...propsB,
};

if ( propsA && propsB && propsA.className && propsB.className ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional?.chaining?.here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can propsA be spread above if it can me nullish?

newProps.className = classnames( propsA.className, propsB.className );
}
if ( propsA && propsB && propsA.style && propsB.style ) {
newProps.style = { ...propsA.style, ...propsB.style };
}

return newProps;
}

function BlockListBlock( {
mode,
isFocusMode,
Expand Down Expand Up @@ -97,10 +121,10 @@ function BlockListBlock( {

// Determine whether the block has props to apply to the wrapper.
if ( blockType.getEditWrapperProps ) {
wrapperProps = {
...wrapperProps,
...blockType.getEditWrapperProps( attributes ),
};
wrapperProps = mergeWrapperProps(
wrapperProps,
blockType.getEditWrapperProps( attributes )
);
}

const generatedClassName =
Expand Down
49 changes: 49 additions & 0 deletions packages/block-editor/src/hooks/color.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { hasBlockSupport, getBlockSupport } from '@wordpress/blocks';
import { __ } from '@wordpress/i18n';
import { useSelect } from '@wordpress/data';
import { useRef, useEffect, Platform } from '@wordpress/element';
import { createHigherOrderComponent } from '@wordpress/compose';

/**
* Internal dependencies
Expand Down Expand Up @@ -334,6 +335,48 @@ export function ColorEdit( props ) {
);
}

/**
* This adds inline styles for color palette colors.
* Ideally, this is not needed and themes should load their palettes on the editor.
*
* @param {Function} BlockListBlock Original component
* @return {Function} Wrapped component
*/
export const withColorPaletteStyles = createHigherOrderComponent(
( BlockListBlock ) => ( props ) => {
const { name, attributes } = props;
const { backgroundColor, textColor } = attributes;
const colors = useSelect( ( select ) => {
return select( 'core/block-editor' ).getSettings().colors;
}, [] );

if ( ! hasColorSupport( name ) ) {
return <BlockListBlock { ...props } />;
}

const extraStyles = {
color: textColor
? getColorObjectByAttributeValues( colors, textColor )?.color
: undefined,
backgroundColor: backgroundColor
? getColorObjectByAttributeValues( colors, backgroundColor )
?.color
: undefined,
};

let wrapperProps = props.wrapperProps;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be a constant?

wrapperProps = {
...props.wrapperProps,
style: {
...extraStyles,
...props.wrapperProps?.style,
oandregal marked this conversation as resolved.
Show resolved Hide resolved
},
};

return <BlockListBlock { ...props } wrapperProps={ wrapperProps } />;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
},
'withColorPaletteStyles'

);

addFilter(
'blocks.registerBlockType',
'core/color/addAttribute',
Expand All @@ -351,3 +394,9 @@ addFilter(
'core/color/addEditProps',
addEditProps
);

addFilter(
'editor.BlockListBlock',
'core/color/with-color-palette-styles',
withColorPaletteStyles
);