-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix editor colors for themes not loading color palettes #22356
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ba34f05
Fix editor colors for themes not loading color palettes
youknowriad 2fc4ead
Fix condition
youknowriad b24b674
try fixing tests
youknowriad 762c12a
Avoid remounting the block if it supports colors
youknowriad bb0ae85
Fix useSelect subscription
ellatrix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -12,6 +12,7 @@ import { hasBlockSupport, getBlockSupport } from '@wordpress/blocks'; | |||||||
import { __ } from '@wordpress/i18n'; | ||||||||
import { useSelect } from '@wordpress/data'; | ||||||||
import { useRef, useEffect, Platform } from '@wordpress/element'; | ||||||||
import { createHigherOrderComponent } from '@wordpress/compose'; | ||||||||
|
||||||||
/** | ||||||||
* Internal dependencies | ||||||||
|
@@ -334,6 +335,48 @@ export function ColorEdit( props ) { | |||||||
); | ||||||||
} | ||||||||
|
||||||||
/** | ||||||||
* This adds inline styles for color palette colors. | ||||||||
* Ideally, this is not needed and themes should load their palettes on the editor. | ||||||||
* | ||||||||
* @param {Function} BlockListBlock Original component | ||||||||
* @return {Function} Wrapped component | ||||||||
*/ | ||||||||
export const withColorPaletteStyles = createHigherOrderComponent( | ||||||||
( BlockListBlock ) => ( props ) => { | ||||||||
const { name, attributes } = props; | ||||||||
const { backgroundColor, textColor } = attributes; | ||||||||
const colors = useSelect( ( select ) => { | ||||||||
return select( 'core/block-editor' ).getSettings().colors; | ||||||||
}, [] ); | ||||||||
|
||||||||
if ( ! hasColorSupport( name ) ) { | ||||||||
return <BlockListBlock { ...props } />; | ||||||||
} | ||||||||
|
||||||||
const extraStyles = { | ||||||||
color: textColor | ||||||||
? getColorObjectByAttributeValues( colors, textColor )?.color | ||||||||
: undefined, | ||||||||
backgroundColor: backgroundColor | ||||||||
? getColorObjectByAttributeValues( colors, backgroundColor ) | ||||||||
?.color | ||||||||
: undefined, | ||||||||
}; | ||||||||
|
||||||||
let wrapperProps = props.wrapperProps; | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This can be a constant? |
||||||||
wrapperProps = { | ||||||||
...props.wrapperProps, | ||||||||
style: { | ||||||||
...extraStyles, | ||||||||
...props.wrapperProps?.style, | ||||||||
oandregal marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
}, | ||||||||
}; | ||||||||
|
||||||||
return <BlockListBlock { ...props } wrapperProps={ wrapperProps } />; | ||||||||
} | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
); | ||||||||
|
||||||||
addFilter( | ||||||||
'blocks.registerBlockType', | ||||||||
'core/color/addAttribute', | ||||||||
|
@@ -351,3 +394,9 @@ addFilter( | |||||||
'core/color/addEditProps', | ||||||||
addEditProps | ||||||||
); | ||||||||
|
||||||||
addFilter( | ||||||||
'editor.BlockListBlock', | ||||||||
'core/color/with-color-palette-styles', | ||||||||
withColorPaletteStyles | ||||||||
); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional?.chaining?.here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can
propsA
be spread above if it can me nullish?