Fix undefined index "colors" warning (#2198) #2253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This resolves one of the two notices related to #2198. There is still another one:
For that reason I think it would be better to follow the other proposed solution in #2198 ("provide abstraction (function getter) to retrieve Gutenberg theme options"). Also, if you put "Fixes #2198" in your PR description it will automatically close that issue when this PR is merged, as well as being a clearer link back to the original issue. |
aduth
reviewed
Aug 7, 2017
| @@ -652,7 +652,7 @@ function gutenberg_editor_scripts_and_styles( $hook ) { | |||
| $gutenberg_theme_support = get_theme_support( 'gutenberg' ); | |||
| $color_palette = gutenberg_color_palette(); | |||
|
|
|||
| if ( $gutenberg_theme_support && $gutenberg_theme_support[0]['colors'] ) { | |||
| if ( $gutenberg_theme_support && isset( $gutenberg_theme_support[0]['colors'] ) && $gutenberg_theme_support[0]['colors'] ) { | |||
There was a problem hiding this comment.
If we're going to test having been set and "truthy"-ness, would it be more concise to use ! empty instead?
if ( $gutenberg_theme_support && ! empty( $gutenberg_theme_support[0]['colors'] ) ) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.