Fix plus. #22704
Merged
Fix plus. #22704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -39 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
Pinging @adamziel just to ensure that we're not going back on forth here. |
|
I'm not sure, looping in @shaunandrews, @draganescu, and @tellthemachines |
draganescu
approved these changes
Jun 15, 2020
There was a problem hiding this comment.
As far as I've seen the create icon has been introduced in #21476 so it is not a feature connected to Navigation or Buttons PRs. I can reproduce this on master:
and this PR fixes that.
|
Looks good to me.
I'm not familiar with the decision behind the two different icons, but the consistency here seems good. |
|
Thanks for the reviews and sanity checks. I'll rebase and merge when I have a moment. |
|
Thanks :) |
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plus in Buttons, Social Links, and Navigation regressed:
This fixes that:
However there's one niggle. We use the same component for the appender in buttons/sociallinks/navigation, as we do for the big generic appender in columns. The latter we intentionally changed to use the smaller plus button, the icon called
create. This PR actually regesses that, so both of those use the same icon:I couldn't immediately figure out how to serve one or the other depending on whether it was the big white background version, or the small black version. Input appreciated.