Fix updateSlot missing from default SlotFillContext #23108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegohaz
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
diegohaz
added
[Package] Components
diegohaz
commented
Jun 12, 2020
| @@ -93,6 +93,7 @@ function useSlotRegistry() { | |||
| slots, | |||
| fills, | |||
| registerSlot, | |||
| updateSlot, | |||
There was a problem hiding this comment.
This was also missing from the React memo deps, although it wasn't making any difference.
|
Size Change: +10 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Jun 12, 2020
There was a problem hiding this comment.
Thanks for a quick fix 💯
As noted in the parent issue: #23014 (comment), we should consider adding warnings when the provider is missing.
Does this component work in expected ways without the provider? When reviewing the code, I got the impression that the Provider was absolutely necessary to get coherent behavior, and it would be preferable to throw an informative error early in the Consumer when it's not mounted under a Provider. |
|
@sirreal, see #23108 (review):
|
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23014
Due to the convention that this module adopts, I think the preferred fix is to simply add
updateSlotas a noop function to the default object that is returned by the context (whenSlotFillProviderisn't present).But I also wonder when using
Slot/FillwithoutSlotFillProviderwould make sense.Failing test: https://travis-ci.com/github/WordPress/gutenberg/jobs/347817325#L3248