Fix possibly outdated onChange in color palette's color picker

[costasovo]

Description

ColorPalette component uses useCallback hook to memoize ColorPicker render function. This memoized renderer is not refreshed when onChange function changes. This causes that onChange function in ColorPicker may become outdated and carries outdated scope. Triggering such an outdated callback may cause issues because it is processed with potentially outdated scope. This PR adds ColorsPalette's onChange callback to the list of dependencies to the memoized ColorPicker render so that the colour picker render method is refreshed after the onChange callback changes.

How has this been tested?

I locally added a component to the ColorsPalette storybook to replicate the issue and checked that the fix works. Without the fix, you can observe that changing colour using the custom colour picker will reset previously set size value.

The component:

export const borderSettings = () => {
	const [ settings, setSettings ] = useState( {
		color: '#f00',
		size: 1,
	} );

	const colorsDef = [
		object( 'Red', { name: 'red', color: '#f00' } ),
		object( 'White', { name: 'white', color: '#fff' } ),
		object( 'Blue', { name: 'blue', color: '#00f' } ),
	];

	console.log(settings);

	return (
		<>
			<RangeControl
				value={ settings.size }
				onChange={ ( val ) => {
					setSettings( {
						...settings,
						size: val,
					} );
				} }
			/>
			<ColorPalette
				colors={ colorsDef }
				value={ settings.color }
				onChange={ ( val ) => {
					setSettings( {
						...settings,
						color: val,
					} );
				} }
			/>
		</>
	);
};

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[youknowriad]

Can we just remove the useCallback call renderCustomColorPicker function. It seems to me that this optimization is not really necessary.

[costasovo]

Good point! 👍

[costasovo]

@youknowriad I've removed the useCallback and rebased the PR.

[youknowriad]

Looks good, thanks for the fix.