Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove z-index from placeholder fieldset #23152

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Remove z-index from placeholder fieldset #23152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5c4e5e
Remove z-index from placeholder fieldset
tellthemachines Jun 15, 2020
c87364a
Remove z-index variable
tellthemachines Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/base-styles/_z-index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ $z-layers: (
// The draggable element should show up above the entire UI
".components-draggable__clone": 1000000000,

// Should have higher index than the inset/underlay used for dragging
".components-placeholder__fieldset": 1,
".block-editor-block-list__block .reusable-block-edit-panel *": 1,

// Show drop zone above most standard content, but below any overlays
Expand Down
1 change: 0 additions & 1 deletion packages/components/src/placeholder/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
flex-direction: row;
width: 100%;
flex-wrap: wrap;
z-index: z-index(".components-placeholder__fieldset");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this was added in the first place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a comment on the other file: // Should have higher index than the inset/underlay used for dragging . Something may have changed since it was added, because the fieldsets are all usable without the z-index. I also tested the dragging functionality (for image blocks and the like) and everything seems fine.


p {
font-family: $default-font;
Expand Down