Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "engines" to the package.json and "engine-strict = true" to the .… #23600

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Add "engines" to the package.json and "engine-strict = true" to the .… #23600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b330d3b
Add "engines" to the package.json and "engine-strict = true" to the .…
ixkaito Jun 30, 2020
6852788
Add "npm": ">=6.9.0" to npm-engines
ixkaito Jul 2, 2020
20f5a8f
Change engines: node to >=10.0.0 according to check-engines
ixkaito Jul 6, 2020
8c03da8
Remove obsolete npm-scripts which check engines
ixkaito Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
save-exact = true
engine-strict = true
7 changes: 4 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
"bugs": {
"url": "https://github.com/WordPress/gutenberg/issues"
},
"engines": {
"node": ">=10.0.0",
"npm": ">=6.9.0"
},
"config": {
"GUTENBERG_PHASE": 2
},
Expand Down Expand Up @@ -199,7 +203,6 @@
},
"scripts": {
"analyze-bundles": "npm run build -- --webpack-bundle-analyzer",
"prebuild": "npm run check-engines",
"clean:packages": "rimraf \"./packages/*/@(build|build-module|build-style)\"",
"clean:package-types": "tsc --build --clean",
"prebuild:packages": "npm run clean:packages && lerna run build",
Expand All @@ -208,11 +211,9 @@
"build:plugin-zip": "./bin/build-plugin-zip.sh",
"build": "npm run build:packages && wp-scripts build",
"changelog": "./bin/plugin/cli.js changelog",
"check-engines": "wp-scripts check-engines",
"check-licenses": "concurrently \"wp-scripts check-licenses --prod --gpl2 --ignore=@react-native-community/cli,@react-native-community/cli-platform-ios\" \"wp-scripts check-licenses --dev\"",
"precheck-local-changes": "npm run docs:build",
"check-local-changes": "( git diff -U0 | xargs -0 node bin/process-git-diff ) || ( echo \"There are local uncommitted changes after one or both of 'npm install' or 'npm run docs:build'!\" && exit 1 );",
"predev": "npm run check-engines",
"dev": "npm run build:packages && concurrently \"wp-scripts start\" \"npm run dev:packages\"",
"dev:packages": "node ./bin/packages/watch.js",
"docs:build": "node ./docs/tool/index.js && node ./bin/api-docs/update-api-docs.js",
Expand Down