[RNMobile] Navigation in bottom-sheet #23782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
pinarol
added
the
Mobile App - i.e. Android or iOS
pinarol
reviewed
Aug 12, 2020
packages/components/src/mobile/bottom-sheet/navigation-screen.native.js
Outdated
Show resolved
Hide resolved
pinarol
reviewed
Aug 12, 2020
packages/components/src/mobile/bottom-sheet/navigation-container.native.js
Outdated
Show resolved
Hide resolved
pinarol
reviewed
Aug 12, 2020
There was a problem hiding this comment.
I tested this with iOS demo app and it looks good. I am only dropping some comments regarding documentation. After that I think this is ready to go.
@lukewalczak Could you test the Android side?
|
Overall it looks really solid! 🎉
|
|
Hey @lukewalczak thanks for your review!
I pushed the fix (here) could you please check it one more time? :) |
2 tasks
pinarol
approved these changes
Aug 13, 2020
3 tasks
|
Tested the latest changes and works as expected, no crash detected 🎉 that's really nice feature! |
3 tasks
lukewalczak
approved these changes
Aug 14, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Main issue: wordpress-mobile/gutenberg-mobile#1884
Wordpress-iOS PR: wordpress-mobile/WordPress-iOS#14474
Wordpress-Android PR: wordpress-mobile/WordPress-Android#12455
Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2549
In this PR i added
react-navigationand used it inside our Bottom-Sheet. This Pr has a long story behind. We wanted to replace the entire Bottom-Sheet toreanimated-bottom-sheetbut unfortunately, there are too many limitations so we decided to keep our current BottomSheet implementation and just add navigation inside.This PR affects all Block Settings.
I implemented some helper mechanisms that will be useful in the future while adding a new screen inside the bottom-sheet. To animate the bottom-sheet height when the navigation is inside we need to set the height of current Screen ( The visible one If we have nested navigators) so I added BottomSheet.NavigationScreen that handles the Android hardware back button and BottomSheet.NavigationContainer to animate height of it.
How has this been tested?
Screenshots
Types of changes
Add 'react-navigation' to the project and add possibilities to use it inside our bottom-sheet.
Checklist: