Update 'Quote' pattern #23881
Update 'Quote' pattern #23881
Conversation
enriquesanchez
added
the
[Feature] Patterns
enriquesanchez
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: -1.02 MB (88%) 🏆 Total Size: 1.15 MB
ℹ️ View Unchanged
|
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
This is cool! Where does the user icon come from? It seems a little inelegant, and I wonder if there's something else we can use. |
@kjellr I'm pulling it from Gravatar.
Would you suggest a variation of that same idea? Or something totally different? |
|
It would be sort of cool to pull an image of Herman Melville if there is a CC0 one (but I know that might open a can of worms around images we can use here). Alternatively, maybe if there's a G2-style icon we can use instead of this one? |
@kjellr Here are a couple of similar graphics using the user icon from G2:
|
|
I was thinking maybe something like this? I matched the background to the default text color, which makes this a little more bold, too.
|
|
That looks great. Will add this graphic to the request already in progress in Trac https://core.trac.wordpress.org/ticket/50650 |
|
Something I'm not certain about is whether or not it is semantically correct to use an |
ZebulanStanphill
added
Needs Accessibility Feedback
|
As a general rule, since the visual use of an HR is the same as its semantic usage, it's semantically correct. There obviously can be cases where a separator isn't really a separator, but usually it's fine. It's fine for there to be an HR used as a separator; that's not a problem. If it's changeable, then it's really not a big deal, as a user can remove it if they don't want a separation. The HR represents a separation; if the user wants a visual separation, then that visual separation should also be represented in the page semantics. I'd actually consider a horizontal rule that creates a visual separation that isn't reflected semantically to be a bigger problem. We can't dictate semantics to a user, because this block pattern doesn't exist within a context; to judge whether an HR is appropriate or not would be dependent on what other content surrounds the content, and isn't inherent to the HR itself. |
|
(Full discussion in the Slack accessibility channel.) Seeing that this is probably fine (and if not, the potential negative impact is minimal), I'm going to go ahead and merge this. It's simple enough to change later if desired. |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Updates the 'Quote' pattern, adds an image on top and a separator at the bottom.
Before:
After: