-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix block icon mouse-out gesture issue. #23980
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After showing the parent block selector and block outline, if you moved your mouse into the parent block selector button for a few seconds and then moved it out, the move-out gesture would not be triggered. This commit fixes that.
ZebulanStanphill
added
[Type] Bug
An existing feature does not function as intended
[Package] Block editor
/packages/block-editor
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
labels
Jul 16, 2020
6 tasks
ZebulanStanphill
changed the title
Fix block icon mouse out gesture issue.
Fix block icon mouse-out gesture issue.
Jul 16, 2020
Size Change: -2 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Jul 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the issue for me. Thanks.
6 tasks
ellatrix
pushed a commit
that referenced
this pull request
Jul 20, 2020
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Block editor
/packages/block-editor
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #23971.
After showing the parent block selector and block outline, if you moved your mouse into the parent block selector button for a few seconds and then moved it out (without moving it back through the block icon), the move-out gesture would not be triggered.
This PR fixes that.
Reproduction steps (for
master
)Checklist: