-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Reduce spacing in slider #24161
Conversation
Size Change: +13 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, and lines up with what I've got in Figma as far as I can tell. Thanks for taking care of it, Luke!
Hey @lukewalczak, i'm wondering what is the difference between this PR and https://github.com/WordPress/gutenberg/pull/23580/files It seems like this should work the same as the reverted one |
Hmm that's interesting 🤔 are we sure then these changes introduced the regression? Do we have a specific case to test to confirm the current changes work properly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work @lukewalczak !! 🎉 Tested it on both iOS and Android.
Description
Fixes wordpress-mobile/gutenberg-mobile#2126
Fixes: wordpress-mobile/gutenberg-mobile#2501
How has this been tested?
Screenshots
Types of changes
Checklist: