-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display labels instead of icons in top toolbar. #24304
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
ed98b65
Add option to show icon labels.
tellthemachines c297f23
Address review feedback and consolidate
tellthemachines 10f78c5
Move option to general section
tellthemachines 30239dc
Remove unnecessary dispatch
tellthemachines 9201cfe
Display labels instead of icons in top toolbar.
tellthemachines dcdfbef
Fix dropdown tooltip display
tellthemachines 5e9f459
Adjust button and toolbar styling.
tellthemachines b4fcdd9
Reposition outline dropdown
tellthemachines 45dc9d1
Try button tertiary styles
tellthemachines 54eede9
Update button styles
tellthemachines f5fd779
Add translator comments to top toolbar buttons.
tellthemachines ec49857
Fix failing tests.
tellthemachines 8fbbfea
Update e2e test selector.
tellthemachines 1c52895
Fix translator comments.
tellthemachines 0a8350b
Change header toolbar menu labels.
tellthemachines 02785d4
Change options labels
tellthemachines fff6bf9
Update snapshot.
tellthemachines e9cb2f1
Update e2e selector
tellthemachines 82a8afa
Change labels
tellthemachines b0191bd
Styling tweaks
tellthemachines 9ada627
Try Settings button inside Options dropdown
tellthemachines e32ad7f
Expand modes in Tools dropdown
tellthemachines 5080c03
Button styling adjustments
tellthemachines 7f6b48c
Fix inserter aria label
tellthemachines b2d59f6
Fix e2e selector.
tellthemachines 20c3e33
Actually change all the e2e selectors.
tellthemachines ff2981c
Styling improvements
tellthemachines 84c9811
Fix buttons on small breakpoint.
tellthemachines 52785f0
Address remaining feedback and style fixes.
tellthemachines File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The disabled items in the overflow menu don't seem to be consistent with other dropdown menus:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, they are meant to be consistent with their out-of-overflow state 😅 but perhaps @mapk can comment further on that.