Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --wp-admin-theme-color reference from front-facing styles #24436

Merged

Conversation

aristath
Copy link
Member

@aristath aristath commented Aug 7, 2020

The title says it all 😆

We recently introduced a new --wp-admin-theme-color CSS-variable.
That somehow stayed in the calendar block, so this PR removes it and the link can keep inheriting the theme's link styles.

@ZebulanStanphill ZebulanStanphill added [Block] Calendar Affects the Calendar Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. CSS Styling Related to editor and front end styles, CSS-specific issues. [Package] Block library /packages/block-library [Type] Bug An existing feature does not function as intended labels Aug 7, 2020
@youknowriad
Copy link
Contributor

youknowriad commented Aug 13, 2020

👍 This is definitely not meant to be a frontend color.

Do you think how safe is it to just remove that rule, do we need to replace it with something else? What impacts this have on themes?

@aristath
Copy link
Member Author

I don't think we need to replace it with something else... With the tfoot a rule missing, the link will simply inherit its color from normal links as it should.
Themes don't use the css-var for admin-theme-color schemes, and since that was only recently introduced the danger of any impact is practically zero. Coupled with the fact that the link will simply inherit its style from normal links this one should be OK 👍

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining further, it makes sense.

@youknowriad youknowriad merged commit 5bfdfe1 into WordPress:master Aug 17, 2020
@github-actions github-actions bot added this to the Gutenberg 8.8 milestone Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Calendar Affects the Calendar Block CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Package] Block library /packages/block-library [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants