-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the unicode character used to represent the macOS Control key #24452
Merged
talldan
merged 1 commit into
master
from
fix/keyboard-shortcuts-macos-control-character
Aug 20, 2020
Merged
Fix the unicode character used to represent the macOS Control key #24452
talldan
merged 1 commit into
master
from
fix/keyboard-shortcuts-macos-control-character
Aug 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
the
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
label
Aug 9, 2020
Size Change: +2 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
ZebulanStanphill
added
the
[Type] Bug
An existing feature does not function as intended
label
Aug 9, 2020
talldan
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix—works well for me when tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the character used to represent the macOS Control key from "U+005E CIRCUMFLEX ACCENT" to "U+2303 UP ARROWHEAD"
How has this been tested?
^
are announced as "caret"⌃
within the keyboard shortcuts modal dialog are announced as "Control"Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
Fixes #24451