Fix: Cover block: Impossible to reset the minimum height value #24490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
jorgefilipecosta
requested review from
ajitbohra,
chrisvanpatten,
Soean,
talldan and
youknowriad
as code owners
|
Size Change: +23 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
ItsJonQ
approved these changes
Aug 11, 2020
There was a problem hiding this comment.
🚀 Looks good to me! Tested locally and it works. Thanks @jorgefilipecosta for helping with this!
Sidenote: I'm not sure what the solution is... but we need to come up with some sort of re-usable + unified system for handling input state, that accommodates being controlled/not-controlled, with reset handling.
As I've learned, reset handling is awkward as the consuming component may expect (or prefer) an empty string or null. In some case, undefined. 🙃
ItsJonQ
deleted the
fix/cover-block-Impossible-to-reset-the-minimum-height-value
branch
|
From an a11y perspective, I think it would be good to show a simple Reset button next to all number/slider controls like this. |
|
Yes, I agree that a reset button similar to what we have on the font size picker would make sense on the unit control component, as most of the times we want to allow the user to reset the field. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #23988
This PR changes the UnitControl component to pass via the onChange cases where the input is made empty.
On the cover block, it resets the units in the cases where there is no value so the value of minimum height is totally reset when the user cleans the field.