Upgrade eslint-plugin-jsdoc to latest version #24586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
requested review from
ajitbohra,
ellatrix,
gziolo,
nerrad,
ntwb and
youknowriad
as code owners
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
ntwb
approved these changes
Aug 16, 2020
Since the ESLint configuration is set as root, it must reconfigure its own JSDoc settings to inform parser that it should treat JSDoc as supporting TypeScript syntax
|
FYI @sirreal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to upgrade the
eslint-plugin-jsdocdependency of@wordpress/eslint-pluginto the latest version, from26.0.0to30.2.2. Newer versions of the plugin include improved support for TypeScript syntax, notably with type intersections. Previously, these were flagged as invalid syntax, and it was frequently required to disable the rule via inline configuration.There is still some unsupported syntax after this upgrade. The upstream issues jsdoctypeparser/jsdoctypeparser#50 and gajus/eslint-plugin-jsdoc#145 serve as tracking resources.
Testing Instructions:
Verify lint passes: