Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid lossy html entities encoding by setting charset #24645

Merged
merged 8 commits into from
Aug 19, 2020
Merged

Avoid lossy html entities encoding by setting charset #24645

merged 8 commits into from
Aug 19, 2020

Commits on Aug 18, 2020

  1. Avoid lossy htmlentities encode by setting charset 

    Sets the charset of the html passed into DomDocument to utf-8.

Replaces the mb_convert_encoding call replacing utf-8 with html entities
before handing off to DomDocument.

This avoids the need to later convert back to utf-8 from html entities
afterward. This secondary mb_convert_encoding call was converting not
only the utf-8 we converted earlier but also entity encoding html stored
inside data-* or other attributes of html elements.

Fixes Automattic/wp-calypso#44897
Maintains the fix for WordPress#24445 (WordPress#24447)
    @lsl
    lsl committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    e623758 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. Block Supports: Make block content unit test more flexible

    @ockham
    ockham committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    7b4bda1 View commit details
    Browse the repository at this point in the history

  2. Block Supports: Add comments to block content unit test helper

    @ockham
    ockham committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    8a2c18f View commit details
    Browse the repository at this point in the history

  3. Block Supports: Cover more cases in unit test

    @ockham
    ockham committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    296bfa9 View commit details
    Browse the repository at this point in the history

  4. str_replace instead of preg_replace

    @ockham
    ockham committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    c321e00 View commit details
    Browse the repository at this point in the history

  5. Comment typos

    @ockham
    ockham committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    3c39e54 View commit details
    Browse the repository at this point in the history

  6. Missing periods

    @ockham
    ockham committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    fbb8c66 View commit details
    Browse the repository at this point in the history

  7. phpcbf

    @ockham
    ockham committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    349a856 View commit details
    Browse the repository at this point in the history