-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block inspector to nav screen #24669
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
draganescu,
talldan,
noisysocks and
shaunandrews
August 20, 2020 01:51
Size Change: +1.23 kB (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
noisysocks
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great from a code perspective. Let's see what @shaunandrews thinks 🙂
packages/edit-navigation/src/components/navigation-editor/block-editor-area.js
Outdated
Show resolved
Hide resolved
I will merge this and we can iterate on it in future PRs from an interaction and visual / usability perspective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #23934
Adds block inspector to Navigation screen, inside a dropdown.
How has this been tested?
Tested in browser and checked keyboard navigation.
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: