Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block inspector to nav screen #24669

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Add block inspector to nav screen #24669

merged 2 commits into from
Aug 24, 2020

Conversation

tellthemachines
Copy link
Contributor

@tellthemachines tellthemachines commented Aug 20, 2020

Description

Closes #23934

Adds block inspector to Navigation screen, inside a dropdown.

How has this been tested?

Tested in browser and checked keyboard navigation.

Screenshots

Screen Shot 2020-08-20 at 11 48 46 am

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions
Copy link

github-actions bot commented Aug 20, 2020

Size Change: +1.23 kB (0%)

Total Size: 1.16 MB

Filename Size Change
build/block-editor/index.js 126 kB +11 B (0%)
build/block-editor/style-rtl.css 10.7 kB +45 B (0%)
build/block-editor/style.css 10.7 kB +44 B (0%)
build/block-library/editor-rtl.css 8.5 kB +140 B (1%)
build/block-library/editor.css 8.5 kB +140 B (1%)
build/block-library/index.js 133 kB +196 B (0%)
build/block-library/style-rtl.css 7.42 kB -23 B (0%)
build/block-library/style.css 7.43 kB -21 B (0%)
build/blocks/index.js 47.6 kB +1 B
build/components/index.js 200 kB +2 B (0%)
build/edit-navigation/index.js 11.5 kB +532 B (4%)
build/edit-navigation/style-rtl.css 1.16 kB +45 B (3%)
build/edit-navigation/style.css 1.16 kB +46 B (3%)
build/edit-post/index.js 304 kB +21 B (0%)
build/edit-site/index.js 17 kB +71 B (0%)
build/edit-widgets/index.js 11.8 kB +1 B
build/editor/index.js 45.3 kB -22 B (0%)
build/format-library/index.js 7.72 kB +1 B
build/keycodes/index.js 1.94 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/api-fetch/index.js 3.44 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.96 kB 0 B
build/block-directory/style-rtl.css 953 B 0 B
build/block-directory/style.css 952 B 0 B
build/block-library/theme-rtl.css 729 B 0 B
build/block-library/theme.css 730 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/components/style-rtl.css 15.7 kB 0 B
build/components/style.css 15.7 kB 0 B
build/compose/index.js 9.68 kB 0 B
build/core-data/index.js 11.8 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.55 kB 0 B
build/date/index.js 5.38 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.47 kB 0 B
build/edit-post/style-rtl.css 5.61 kB 0 B
build/edit-post/style.css 5.61 kB 0 B
build/edit-site/style-rtl.css 3.06 kB 0 B
build/edit-site/style.css 3.06 kB 0 B
build/edit-widgets/style-rtl.css 2.45 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/style-rtl.css 3.8 kB 0 B
build/editor/style.css 3.79 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/list-reusable-blocks/index.js 3.11 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.33 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.41 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.9 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@noisysocks noisysocks added the Needs Design Feedback Needs general design feedback. label Aug 20, 2020
Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great from a code perspective. Let's see what @shaunandrews thinks 🙂

@draganescu
Copy link
Contributor

I will merge this and we can iterate on it in future PRs from an interaction and visual / usability perspective.

@draganescu draganescu merged commit 3c1a587 into master Aug 24, 2020
@draganescu draganescu deleted the try/nav-screen-sidebar branch August 24, 2020 10:22
@github-actions github-actions bot added this to the Gutenberg 8.9 milestone Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation screen: Add support for advanced block properties
3 participants