Enable back dropCap for paragraph #24930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +22 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Aug 31, 2020
| const blockSupportValue = getBlockSupport( blockName, path ); | ||
| if ( blockSupportValue !== undefined ) { | ||
| return blockSupportValue; | ||
| } |
There was a problem hiding this comment.
Why do we need to check block support here? I think we should remove that check entirely from here. the useEditorFeature should be just about theme.json and block-editor setting and the hook should check for block support. At least that's my reasoning for the change.
There was a problem hiding this comment.
Actually, I think the issue is on Core's experimental-default-theme.json. It should be "true" there and not disabled. This fil e corresponds to the default value for Core if I'm not wrong.
|
Super-seeded by #24932 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced at #24761 by which the paragraph block lost the dropCap control.