Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data: add a comment about why we normalize resolvers to objects with fulfill method #25102

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Data: add a comment about why we normalize resolvers to objects with fulfill method #25102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions packages/data/src/namespace-store/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,13 +252,21 @@ function mapActions( actions, store ) {
* @param {Object} resolvers Resolvers to register.
* @param {Object} selectors The current selectors to be modified.
* @param {Object} store The redux store to which the resolvers should be mapped.
* @param {Object} queue Resolvers async queue.
* @param {Object} resolversCache Resolvers Cache.
*/
function mapResolvers( resolvers, selectors, store, resolversCache ) {
// The `resolver` can be either a function that does the resolution, or, in more advanced
// cases, an object with a `fullfill` method and other optional methods like `isFulfilled`.
// Here we normalize the `resolver` function to an object with `fulfill` method.
const mappedResolvers = mapValues( resolvers, ( resolver ) => {
const { fulfill: resolverFulfill = resolver } = resolver;
return { ...resolver, fulfill: resolverFulfill };
if ( resolver.fulfill ) {
return resolver;
}

return {
...resolver, // copy the enumerable properties of the resolver function
fulfill: resolver, // add the fulfill method
};
} );

const mapSelector = ( selector, selectorName ) => {
Expand Down