Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar: Refactor page attributes to use withAPIData #2522

Merged
merged 1 commit into from
Aug 28, 2017

Conversation

aduth
Copy link
Member

@aduth aduth commented Aug 24, 2017

Related: #1957, #1974

This pull request seeks to refactor Page Attributes sidebar component to use withAPIData instead of its own internal management of fetch requests.

Testing instructions:

Repeat testing instructions from #1957

@aduth aduth added the General Interface Parts of the UI which don't fall neatly under other labels. label Aug 24, 2017
@codecov
Copy link

codecov bot commented Aug 24, 2017

Codecov Report

Merging #2522 into master will increase coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2522      +/-   ##
==========================================
+ Coverage    30.2%   30.26%   +0.05%     
==========================================
  Files         174      174              
  Lines        5270     5267       -3     
  Branches      900      899       -1     
==========================================
+ Hits         1592     1594       +2     
+ Misses       3121     3117       -4     
+ Partials      557      556       -1
Impacted Files Coverage Δ
editor/sidebar/page-attributes/index.js 73.68% <66.66%> (+19.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f0fe6f...500cc4f. Read the comment docs.

@aduth aduth force-pushed the update/page-attributes-with-api-data branch from 38696bd to 500cc4f Compare August 27, 2017 23:46
@aduth aduth merged commit 72d4d00 into master Aug 28, 2017
@aduth aduth deleted the update/page-attributes-with-api-data branch August 28, 2017 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant